LibWeb: Always flush character insertions before exiting HTML parser #1469

awesomekling · 2024-09-21T07:32:53Z

This fixes an issue where document.write() with only text input would leave all the character data as unflushed text in the parser.

This fixes many of the WPT tests for document.write().

Tested with Meta/WPT.sh run html/webappapis/dynamic-markup-insertion/document-write

Before:

Ran 87 tests finished in 44.4 seconds.
  • 37 ran as expected. 0 tests skipped.
  • 1 tests crashed unexpectedly
  • 5 tests timed out unexpectedly
  • 48 tests had unexpected subtest results

After:

Ran 87 tests finished in 41.6 seconds.
  • 49 ran as expected. 0 tests skipped.
  • 2 tests crashed unexpectedly
  • 5 tests timed out unexpectedly
  • 35 tests had unexpected subtest results

Fixes #970

This fixes an issue where document.write() with only text input would leave all the character data as unflushed text in the parser. This fixes many of the WPT tests for document.write().

AtkinsSJ · 2024-09-21T07:41:27Z

Fixes #970

LibWeb: Always flush character insertions before exiting HTML parser

d225c40

This fixes an issue where document.write() with only text input would leave all the character data as unflushed text in the parser. This fixes many of the WPT tests for document.write().

awesomekling merged commit a0ed12e into LadybirdBrowser:master Sep 21, 2024
5 of 6 checks passed

awesomekling deleted the document-write-flush-character-insertions branch September 21, 2024 08:05

This was referenced Nov 10, 2024

merge button broken SerenityOS/serenity#25343

Closed

Cherry-pick 29.75 Ladybird PRs SerenityOS/serenity#25345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LibWeb: Always flush character insertions before exiting HTML parser #1469

LibWeb: Always flush character insertions before exiting HTML parser #1469

awesomekling commented Sep 21, 2024 •

edited

Loading

AtkinsSJ commented Sep 21, 2024

LibWeb: Always flush character insertions before exiting HTML parser #1469

LibWeb: Always flush character insertions before exiting HTML parser #1469

Conversation

awesomekling commented Sep 21, 2024 • edited Loading

AtkinsSJ commented Sep 21, 2024

awesomekling commented Sep 21, 2024 •

edited

Loading